Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quiet libSDFormat console on --verbose 0 #1621

Merged
merged 3 commits into from
Jul 29, 2022
Merged

Conversation

chapulina
Copy link
Contributor

Summary

SDFormat only has 2 levels: quiet / loud. Let sim users at least suppress all SDF console output with zero verbosity.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina requested a review from scpeters July 29, 2022 20:31
@chapulina chapulina added the 🏰 citadel Ignition Citadel label Jul 29, 2022
scpeters added 2 commits July 29, 2022 14:59
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@codecov
Copy link

codecov bot commented Jul 29, 2022

Codecov Report

Merging #1621 (2264631) into ign-gazebo3 (61dc78d) will decrease coverage by 0.00%.
The diff coverage is 75.00%.

@@               Coverage Diff               @@
##           ign-gazebo3    #1621      +/-   ##
===============================================
- Coverage        78.02%   78.02%   -0.01%     
===============================================
  Files              254      254              
  Lines            14932    14935       +3     
===============================================
+ Hits             11651    11653       +2     
- Misses            3281     3282       +1     
Impacted Files Coverage Δ
src/ign.cc 72.25% <75.00%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61dc78d...2264631. Read the comment docs.

@chapulina chapulina merged commit e2a4d93 into ign-gazebo3 Jul 29, 2022
@chapulina chapulina deleted the chapulina/3/sdf_quiet branch July 29, 2022 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants