Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use stepping field in message #1612

Merged
merged 2 commits into from
Jul 26, 2022
Merged

Use stepping field in message #1612

merged 2 commits into from
Jul 26, 2022

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Jul 26, 2022

🎉 New feature

Uses the stepping field in the world statistics message that became available in: gazebosim/gz-msgs#199

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Use stepping field in message
6a6c210 
Signed-off-by: Nate Koenig <nate@openrobotics.org>
@nkoenig nkoenig added the 🌱 garden Ignition Garden label Jul 26, 2022
@nkoenig nkoenig requested a review from chapulina as a code owner July 26, 2022 19:40
@nkoenig nkoenig mentioned this pull request Jul 26, 2022
Merged
4 tasks
@chapulina chapulina added the bug Something isn't working label Jul 26, 2022
chapulina
chapulina approved these changes Jul 26, 2022
View reviewed changes
deprecated
23c0e7d 
Signed-off-by: Nate Koenig <nate@openrobotics.org>
@nkoenig nkoenig merged commit eabad2d into main Jul 26, 2022
@nkoenig nkoenig deleted the step_msg branch July 26, 2022 22:03
@chapulina
Copy link
Contributor

This broke CI on the main branch. We needed gz-msgs nightlies with the new field before merging. I've triggered them now:

  • Jammy Build Status
  • Focal Build Status

@j-rivero j-rivero mentioned this pull request Sep 16, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

Assignees
No one assigned
Labels
bug Something isn't working 🌱 garden Ignition Garden
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nkoenig @chapulina