-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Component Inspector with common widget pose plotting #1607
Conversation
Signed-off-by: youhy <haoyuan2019@outlook.com>
Signed-off-by: youhy <haoyuan2019@outlook.com>
Codecov Report
@@ Coverage Diff @@
## ign-gazebo6 #1607 +/- ##
===============================================
+ Coverage 64.40% 64.43% +0.02%
===============================================
Files 320 320
Lines 25892 25892
===============================================
+ Hits 16677 16683 +6
+ Misses 9215 9209 -6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, will approve once a new gz-gui6 has been released. Left some minor comments
Signed-off-by: youhy <haoyuan2019@outlook.com>
Signed-off-by: youhy haoyuan2019@outlook.com
New feature
As mentioned here #1571. This PR implements the component inspector's pose with the common widget pose that has the plotting feature. Then we can forward-port gz-sim citadel (3) to fortress (6) without a recession of features.
This PR should be merged after both gazebosim/gz-gui#439 and the forward porting for #1571 from citadel to fortress are merged.
Summary
See GIF in gazebosim/gz-gui#439
Test it
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.