-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use pytest to generate junit xml files for python tests #1562
Conversation
Signed-off-by: ahcorde <ahcorde@gmail.com>
Codecov Report
@@ Coverage Diff @@
## ign-gazebo6 #1562 +/- ##
============================================
Coverage 64.01% 64.01%
============================================
Files 317 317
Lines 25635 25635
============================================
Hits 16410 16410
Misses 9225 9225 Continue to review full report at Codecov.
|
I see that |
Signed-off-by: ahcorde <ahcorde@gmail.com>
I can see the test here https://build.osrfoundation.org/job/ignition_gazebo-ci-pr_any-ubuntu_auto-amd64/9043/testReport/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, I see the test now on Jenkins, thanks for the link!
Signed-off-by: ahcorde <ahcorde@gmail.com> Signed-off-by: Liam Han <liamhan0905@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com> Signed-off-by: Liam Han <liamhan0905@gmail.com>
Signed-off-by: ahcorde ahcorde@gmail.com
🦟 Bug fix
Summary
Python unit tests currently don't generate junit xml files for consumption by Jenkins. This results in Jenkins indicating that there are no failing tests when python tests are failing. couldn't find a way to generate these files using the builtin
unittest
python library, so I have added a dependency onpytest
. Ifpytest
is not available, a CMake warning is emitted.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.