Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BACKPORT] Fix faulty assumption in INTEGRATION_log_system (#1426) #1531

Merged
merged 1 commit into from
Jun 9, 2022

Conversation

Blast545
Copy link
Contributor

@Blast545 Blast545 commented Jun 9, 2022

Signed-off-by: Michael Carroll michael@openrobotics.org

🦟 Bug fix

Summary

Backports #1426 to Citadel, should fix this test regression:
https://build.osrfoundation.org/job/ignition_gazebo-ci-ign-gazebo3-focal-amd64/19/testReport/(root)/LogSystemTest/LogDefaults/

Checklist

  • Signed all commits for DCO
  • Added tests -> Not added, but fixed (some of) them
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Signed-off-by: Michael Carroll <michael@openrobotics.org>
@Blast545 Blast545 requested a review from chapulina as a code owner June 9, 2022 15:11
@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

❗ No coverage uploaded for pull request base (ign-gazebo3@5bb179f). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             ign-gazebo3    #1531   +/-   ##
==============================================
  Coverage               ?   77.76%           
==============================================
  Files                  ?      250           
  Lines                  ?    14443           
  Branches               ?        0           
==============================================
  Hits                   ?    11231           
  Misses                 ?     3212           
  Partials               ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bb179f...5fc071a. Read the comment docs.

@Blast545
Copy link
Contributor Author

Blast545 commented Jun 9, 2022

All tests passed + approval, merging.

@Blast545 Blast545 merged commit 900583a into ign-gazebo3 Jun 9, 2022
@Blast545 Blast545 deleted the blast545/backport_citadel_1426 branch June 9, 2022 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants