Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ian Chen ichen@osrfoundation.org
🦟 Bug fix
Summary
This should fix the test failure when running
INTEGRATION_sensors_system_battery
. The expected image count is updated to allow for one extra image received.More info:
#1480 broke this test. The side effect of that PR is that there is a change in timing of the rendering thread in sensors system - the rendering loop is now running faster before any subscribers and created. When the subscribers are created, the first camera / depth camera images are now rendered at an earlier timestep (because they do not need to wait for previous updates to finish). Because of this slight change in timing, they publish one extra image with the given time period.
Here are sample debug outputs showing the timestamp of the camera image, in
sec nsec
:before:
after:
The above output shows that the update rates are still correct and the rest of the integration test ensures no images are published after the battery is drained.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.