Add missing gz-math includes #1525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some libsdformat headers used to include `gz/math.hh`, but that is no longer the case since gazebosim/sdformat#1043. As a result, gz-sim has to be updated to include the necessary headers. Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
azeey
commented
Jun 8, 2022
chapulina
approved these changes
Jun 8, 2022
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
methylDragon
approved these changes
Jun 8, 2022
Codecov Report
@@ Coverage Diff @@
## main #1525 +/- ##
=======================================
Coverage 63.62% 63.62%
=======================================
Files 330 330
Lines 25784 25784
=======================================
Hits 16405 16405
Misses 9379 9379
Continue to review full report at Codecov.
|
scpeters
added a commit
that referenced
this pull request
Jun 8, 2022
Follow up to #1525. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters
added a commit
that referenced
this pull request
Jun 8, 2022
Follow up to #1525. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
8 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
Some libsdformat headers used to include
gz/math.hh, but that is no longer the case since gazebosim/sdformat#1043. As a result, gz-sim has to be updated to include the necessary headers.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.