Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use 'EachNew' in ForceTorque PreUpdate function #1523

Merged
merged 13 commits into from
Jul 21, 2022

Conversation

mjcarroll
Copy link
Contributor

@mjcarroll mjcarroll commented Jun 7, 2022

🦟 Bug fix

Split from #1471 to address force-torque sensor incrementally.
Partially addresses #797

Summary

Not all sensor system implementations were updated as part of #1281, one of which being the ForceTorqueSensor. This makes the reset behavior incorrect and the sensor won't be respawned.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll mjcarroll requested a review from chapulina as a code owner June 7, 2022 16:46
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@codecov
Copy link

codecov bot commented Jun 7, 2022

Codecov Report

Merging #1523 (83b8e5e) into main (a3cbd8c) will decrease coverage by 0.04%.
The diff coverage is 99.31%.

❗ Current head 83b8e5e differs from pull request most recent head c40453a. Consider uploading reports for the commit c40453a to get more accurate results

@@            Coverage Diff             @@
##             main    #1523      +/-   ##
==========================================
- Coverage   63.62%   63.58%   -0.05%     
==========================================
  Files         330      330              
  Lines       25787    25942     +155     
==========================================
+ Hits        16408    16494      +86     
- Misses       9379     9448      +69     
Impacted Files Coverage Δ
include/gz/sim/EventManager.hh 79.16% <ø> (ø)
include/gz/sim/Util.hh 100.00% <ø> (ø)
include/gz/sim/components/Factory.hh 97.53% <80.00%> (-1.18%) ⬇️
include/gz/sim/EntityComponentManager.hh 100.00% <100.00%> (ø)
include/gz/sim/Link.hh 100.00% <100.00%> (ø)
include/gz/sim/Model.hh 100.00% <100.00%> (ø)
include/gz/sim/SdfEntityCreator.hh 100.00% <100.00%> (ø)
include/gz/sim/Server.hh 100.00% <100.00%> (ø)
include/gz/sim/ServerConfig.hh 100.00% <100.00%> (ø)
include/gz/sim/SystemLoader.hh 100.00% <100.00%> (ø)
... and 132 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17bae14...c40453a. Read the comment docs.

@mjcarroll mjcarroll self-assigned this Jun 13, 2022
@chapulina chapulina added the 🌱 garden Ignition Garden label Jun 14, 2022
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I just have some minor comments.

It would be ideal to target this at Fortress and forward-port, to reduce the diff between the branches. If it's easier for you we can also backport this after merged.

@chapulina chapulina self-requested a review June 27, 2022 18:58
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the return comment addressed, and the other comment is up to you.

mjcarroll and others added 5 commits July 19, 2022 16:13
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@mjcarroll
Copy link
Contributor Author

@osrf-jenkins retest this please

@mjcarroll mjcarroll merged commit 8a651db into main Jul 21, 2022
@mjcarroll mjcarroll deleted the force_torque_preupdate branch July 21, 2022 21:30
@j-rivero j-rivero mentioned this pull request Sep 16, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants