Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added particle emitters to scene broadcaster #1516

Merged
merged 6 commits into from
Jun 23, 2022

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Jun 3, 2022

Signed-off-by: Nate Koenig nate@openrobotics.org

🎉 New feature

Summary

Adds particle emitters to the scene broadcaster.

Test it

You can either run the test, or run world with a particle emitter and manually call the scene/info service.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Nate Koenig <nate@openrobotics.org>
@nkoenig nkoenig requested a review from chapulina as a code owner June 3, 2022 17:57
Signed-off-by: Nate Koenig <nate@openrobotics.org>
@codecov
Copy link

codecov bot commented Jun 3, 2022

Codecov Report

Merging #1516 (1d856cd) into ign-gazebo6 (9c60c16) will increase coverage by 0.02%.
The diff coverage is 94.73%.

@@               Coverage Diff               @@
##           ign-gazebo6    #1516      +/-   ##
===============================================
+ Coverage        63.98%   64.00%   +0.02%     
===============================================
  Files              317      317              
  Lines            25509    25528      +19     
===============================================
+ Hits             16321    16339      +18     
- Misses            9188     9189       +1     
Impacted Files Coverage Δ
src/systems/scene_broadcaster/SceneBroadcaster.cc 92.43% <94.73%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0388cf...1d856cd. Read the comment docs.

@chapulina chapulina added the 🏯 fortress Ignition Fortress label Jun 6, 2022
@chapulina chapulina requested a review from caguero June 13, 2022 18:59
Copy link
Contributor

@caguero caguero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@chapulina chapulina merged commit 4f8c91b into ign-gazebo6 Jun 23, 2022
@chapulina chapulina deleted the scenebraodcaster-particles branch June 23, 2022 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants