Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scene update resource finder #1508

Merged
merged 8 commits into from
May 31, 2022
Merged

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented May 25, 2022

🎉 New feature

Summary

This adds a /gazebo/resource_paths/resolve service that will return the full path to a file on disk when provided with a URI. Only Fuel and IGN_GAZEBO_RESOURCE_PATH are checked.

This also stores the <scene> information the SceneBroadcaster so that the scene/info service can send over <scene> information.

Test

Path resolver

ign service -s /gazebo/resource_paths/resolve --reqtype ignition.msgs.StringMsg --reptype ignition.msgs.StringMsg --timeout 2000 --req "data:'/tmp'"

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • [] All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Nate Koenig added 3 commits May 20, 2022 11:16
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
@nkoenig nkoenig requested a review from chapulina as a code owner May 25, 2022 22:08
Signed-off-by: Nate Koenig <nate@openrobotics.org>
@codecov
Copy link

codecov bot commented May 25, 2022

Codecov Report

Merging #1508 (5b85919) into ign-gazebo6 (62272db) will not change coverage.
The diff coverage is n/a.

❗ Current head 5b85919 differs from pull request most recent head dfb3ec2. Consider uploading reports for the commit dfb3ec2 to get more accurate results

@@             Coverage Diff              @@
##           ign-gazebo6    #1508   +/-   ##
============================================
  Coverage        33.58%   33.58%           
============================================
  Files               44       44           
  Lines             2260     2260           
============================================
  Hits               759      759           
  Misses            1501     1501           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b6c0f2...dfb3ec2. Read the comment docs.

Nate Koenig added 2 commits May 26, 2022 13:28
Signed-off-by: Nate Koenig <nate@openrobotics.org>
…otics/ign-gazebo into scene_update_resource_finder
Copy link
Contributor

@caguero caguero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a minor fix in 99a868f

@nkoenig nkoenig merged commit 26f67fa into ign-gazebo6 May 31, 2022
@nkoenig nkoenig deleted the scene_update_resource_finder branch May 31, 2022 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants