Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trivial issue with Documentation heading in Readme #1501

Merged
merged 2 commits into from
May 19, 2022

Conversation

arjo129
Copy link
Contributor

@arjo129 arjo129 commented May 19, 2022

🦟 Bug fix

Currently the Documentation heading (and link) is broken in our readme. Probably due to some weird unicode issue where the space character is an impostor. This PR fixes it.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

arjo129 added 2 commits May 19, 2022 10:02
Seems like some weird unicode issue was causing The documentation header not to be parsed as documentation.

Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
@arjo129 arjo129 requested a review from chapulina as a code owner May 19, 2022 02:07
@codecov
Copy link

codecov bot commented May 19, 2022

Codecov Report

Merging #1501 (c3112a1) into ign-gazebo6 (f4198be) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           ign-gazebo6    #1501   +/-   ##
============================================
  Coverage        33.58%   33.58%           
============================================
  Files               44       44           
  Lines             2260     2260           
============================================
  Hits               759      759           
  Misses            1501     1501           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4198be...c3112a1. Read the comment docs.

@ahcorde ahcorde merged commit f3686aa into ign-gazebo6 May 19, 2022
@ahcorde ahcorde deleted the arjo/fix/readme_minor_issue branch May 19, 2022 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants