Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete unused gazebo.hh.in #1490

Merged
merged 1 commit into from
May 16, 2022
Merged

Conversation

scpeters
Copy link
Member

🦟 Bug fix

Remove unused header file template

Summary

This was noticed in #1477 (comment), but it's not used (and wouldn't work anyway), so we can delete it.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@methylDragon
Copy link
Contributor

The ignition/gazebo/gazebo.hh.in was renamed to gz/sim/sim.hh.in in #1477

I suppose I should create a gazebo.hh.in in gz/sim/ though since CMake is currently using the gazebo project name which is causing gazebo.hh to be generated.

Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nice catch, thanks @scpeters . Yeah I was wondering about how could that syntax work.

@codecov
Copy link

codecov bot commented May 16, 2022

Codecov Report

Merging #1490 (a8d9ca2) into ign-gazebo3 (738579d) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           ign-gazebo3    #1490   +/-   ##
============================================
  Coverage        34.67%   34.67%           
============================================
  Files               31       31           
  Lines             1993     1993           
============================================
  Hits               691      691           
  Misses            1302     1302           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 738579d...a8d9ca2. Read the comment docs.

@scpeters scpeters merged commit a4b7e85 into ign-gazebo3 May 16, 2022
@scpeters scpeters deleted the scpeters/remove_gazebo.hh.in branch May 16, 2022 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants