Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new GZ_GUI_RESOURCE_PATH to help message #1470

Merged
merged 1 commit into from
Jun 6, 2022

Conversation

mabelzhang
Copy link
Contributor

🎉 New feature

Trivial followup to gazebosim/gz-gui#386

Summary

Trivial PR.

Test it

Check the new var is printed:

$ ign gazebo --help
...
  GZ_GUI_RESOURCE_PATH    Colon separated paths used to locate GUI      
 resources such as configuration files.
...

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
@mabelzhang mabelzhang requested a review from chapulina as a code owner May 3, 2022 20:02
@mabelzhang mabelzhang changed the base branch from ign-gazebo6 to ign-gazebo3 May 3, 2022 20:02
@codecov
Copy link

codecov bot commented May 3, 2022

Codecov Report

Merging #1470 (3728963) into ign-gazebo3 (5994f6d) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           ign-gazebo3    #1470   +/-   ##
============================================
  Coverage        34.67%   34.67%           
============================================
  Files               31       31           
  Lines             1993     1993           
============================================
  Hits               691      691           
  Misses            1302     1302           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5994f6d...3728963. Read the comment docs.

@chapulina chapulina added the 🏰 citadel Ignition Citadel label Jun 6, 2022
@chapulina chapulina added the OOBE 📦✨ Out-of-box experience label Jun 6, 2022
@chapulina chapulina merged commit 5bb179f into ign-gazebo3 Jun 6, 2022
@chapulina chapulina deleted the mabelzhang/gui_env_var branch June 6, 2022 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel OOBE 📦✨ Out-of-box experience
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants