Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove internal python bindings for sdformat #1447

Merged
merged 1 commit into from
Apr 16, 2022
Merged

Remove internal python bindings for sdformat #1447

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions python/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,20 +64,6 @@ target_link_libraries(common PRIVATE
ignition-common${IGN_COMMON_VER}::ignition-common${IGN_COMMON_VER}
)

# TODO(ahcorde): Move this module to sdformat
pybind11_add_module(sdformat SHARED
src/ignition/sdformat/_sdformat_pybind11.cc
src/ignition/sdformat/Element.cc
)

target_link_libraries(sdformat PRIVATE
sdformat${SDF_VER}::sdformat${SDF_VER}
)

install(TARGETS sdformat
DESTINATION "${IGN_PYTHON_INSTALL_PATH}"
)

configure_build_install_location(gazebo)
configure_build_install_location(common)

Expand All @@ -88,7 +74,6 @@ if ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "Clang")
if(${pybind11_VERSION} VERSION_LESS "2.4.4")
target_compile_options(common PRIVATE -fsized-deallocation)
target_compile_options(gazebo PRIVATE -fsized-deallocation)
target_compile_options(sdformat PRIVATE -fsized-deallocation)
endif()
endif()

Expand Down
3 changes: 1 addition & 2 deletions python/src/ignition/gazebo/wrap_functions.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,8 +287,7 @@ struct wrap_ref_ptr : public wrap_arg_default<T> {};

template <typename T>
struct wrap_ref_ptr<T&,
std::enable_if_t<is_generic_pybind_v<T> &&
!std::is_same_v<T, const std::shared_ptr<const sdf::Element>> >> {
std::enable_if_t<is_generic_pybind_v<T>>> {
// NOLINTNEXTLINE[runtime/references]: Intentional.
static T* wrap(T& arg) { return &arg; }
static T& unwrap(T* arg_wrapped) {
Expand Down
36 changes: 0 additions & 36 deletions python/src/ignition/sdformat/Element.cc
View file
Open in desktop

This file was deleted.

38 changes: 0 additions & 38 deletions python/src/ignition/sdformat/Element.hh
View file
Open in desktop

This file was deleted.

23 changes: 0 additions & 23 deletions python/src/ignition/sdformat/_sdformat_pybind11.cc
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion python/test/testFixture_TEST.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
from ignition.common import set_verbosity
from ignition.gazebo import TestFixture, World, world_entity
from ignition.math import Vector3d
from sdformat import Element

post_iterations = 0
iterations = 0
Expand Down