Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Camera trigger integration test #1384

Merged
merged 19 commits into from
May 6, 2022

Conversation

WilliamLewww
Copy link
Contributor

🎉 Camera trigger world

Depends on:

Summary

Created a camera trigger world to be used with the ros_ign example.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
@WilliamLewww WilliamLewww requested a review from chapulina as a code owner March 10, 2022 22:34
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Mar 10, 2022
@chapulina chapulina added sensors Sensors and sensor data needs upstream release Blocked by a release of an upstream library labels Mar 10, 2022
@codecov
Copy link

codecov bot commented Mar 10, 2022

Codecov Report

Merging #1384 (1bdd147) into ign-gazebo6 (269c9b9) will not change coverage.
The diff coverage is n/a.

❗ Current head 1bdd147 differs from pull request most recent head 8a3ba8f. Consider uploading reports for the commit 8a3ba8f to get more accurate results

@@             Coverage Diff              @@
##           ign-gazebo6    #1384   +/-   ##
============================================
  Coverage        33.58%   33.58%           
============================================
  Files               44       44           
  Lines             2260     2260           
============================================
  Hits               759      759           
  Misses            1501     1501           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 212aaed...8a3ba8f. Read the comment docs.

Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

examples/worlds/triggered_camera_sensor.sdf

@WilliamLewww WilliamLewww marked this pull request as draft March 11, 2022 18:20
@WilliamLewww
Copy link
Contributor Author

Put into draft to make an integration test.

Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
@WilliamLewww WilliamLewww changed the title Camera trigger world Camera trigger integration test Mar 14, 2022
Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
@WilliamLewww WilliamLewww marked this pull request as ready for review March 17, 2022 19:30
@WilliamLewww
Copy link
Contributor Author

Test failures irrelevant to pull request.

Ubuntu CI / Ubuntu Jammy CI (pull_request):
   The following tests FAILED:
  	 55 - UNIT_Gui_TEST (SEGFAULT)

ignition_gazebo-ci-pr_any-homebrew-amd64:
   The following tests FAILED:
	 29 - UNIT_SimulationRunner_TEST (SEGFAULT)
	239 - testFixture_TEST.py (Failed)

@chapulina chapulina requested a review from ahcorde May 2, 2022 18:56
@codecov
Copy link

codecov bot commented May 6, 2022

Codecov Report

Merging #1384 (839df66) into ign-gazebo6 (52d12f1) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           ign-gazebo6    #1384   +/-   ##
============================================
  Coverage        33.58%   33.58%           
============================================
  Files               44       44           
  Lines             2260     2260           
============================================
  Hits               759      759           
  Misses            1501     1501           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52d12f1...839df66. Read the comment docs.

@WilliamLewww WilliamLewww merged commit c7e0b21 into gazebosim:ign-gazebo6 May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress needs upstream release Blocked by a release of an upstream library sensors Sensors and sensor data
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants