-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement reset interface in the physics system #1327
Conversation
142ecb1
to
5d44df1
Compare
Reduces the size of simulationrunner header a bit Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org> Signed-off-by: Michael Carroll <michael@openrobotics.org>
Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org> Signed-off-by: Michael Carroll <michael@openrobotics.org>
Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org> Signed-off-by: Michael Carroll <michael@openrobotics.org>
Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org> Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
433545b
to
e3368e5
Compare
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## main #1327 +/- ##
===========================================
+ Coverage 35.01% 62.42% +27.40%
===========================================
Files 44 317 +273
Lines 2356 24562 +22206
===========================================
+ Hits 825 15333 +14508
- Misses 1531 9229 +7698 Continue to review full report at Codecov.
|
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org> Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to add a full description for this PR. It only refers to another PR that doesn't explain anything about this one.
Are there plans to support models that are created or removed during the simulation? This limitation should be documented somewhere.
The PR looks good to me besides the comments below 👍🏽
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## main #1327 +/- ##
=======================================
Coverage 35.01% 35.01%
=======================================
Files 44 44
Lines 2356 2356
=======================================
Hits 825 825
Misses 1531 1531 Continue to review full report at Codecov.
|
I believe all the CI failures are pre-existing |
This builds upon the reset interface for systems introduced in #1249 by implementing the interface for the
Physics
system.Upon receiving a reset command, this allows the physics plugin to rewind to the initial state of the world without removing and re-adding all of the entities.