Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement reset interface in the physics system #1327

Merged
merged 28 commits into from
May 17, 2022
Merged

Implement reset interface in the physics system #1327

merged 28 commits into from
May 17, 2022

Conversation

mjcarroll
Copy link
Contributor

@mjcarroll mjcarroll commented Feb 8, 2022

This builds upon the reset interface for systems introduced in #1249 by implementing the interface for the Physics system.

Upon receiving a reset command, this allows the physics plugin to rewind to the initial state of the world without removing and re-adding all of the entities.

mjcarroll and others added 10 commits February 21, 2022 13:56
Reduces the size of simulationrunner header a bit

Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@chapulina chapulina added the 🌱 garden Ignition Garden label Mar 10, 2022
Base automatically changed from reset to main March 22, 2022 20:21
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@codecov
Copy link

codecov bot commented Mar 29, 2022

Codecov Report

Merging #1327 (32d21f5) into main (e399431) will increase coverage by 27.40%.
The diff coverage is 58.49%.

❗ Current head 32d21f5 differs from pull request most recent head fbf6d0e. Consider uploading reports for the commit fbf6d0e to get more accurate results

@@             Coverage Diff             @@
##             main    #1327       +/-   ##
===========================================
+ Coverage   35.01%   62.42%   +27.40%     
===========================================
  Files          44      317      +273     
  Lines        2356    24562    +22206     
===========================================
+ Hits          825    15333    +14508     
- Misses       1531     9229     +7698     
Impacted Files Coverage Δ
src/systems/physics/Physics.hh 100.00% <ø> (ø)
src/systems/physics/Physics.cc 66.00% <55.10%> (ø)
src/systems/physics/CanonicalLinkModelTracker.hh 100.00% <100.00%> (ø)
...ins/component_inspector/moc_ComponentInspector.cpp
src/gui/plugins/plot_3d/moc_Plot3D.cpp
src/gui/plugins/entity_tree/qrc_EntityTree.cpp
...c/gui/plugins/scene_manager/qrc_GzSceneManager.cpp
src/gui/plugins/spawn/moc_Spawn.cpp
...n-gazebo7-gui_autogen/EWIEGA46WW/moc_GuiRunner.cpp
...gui/plugins/select_entities/qrc_SelectEntities.cpp
... and 354 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7063d41...fbf6d0e. Read the comment docs.

Signed-off-by: Michael Carroll <michael@openrobotics.org>
mjcarroll and others added 3 commits March 30, 2022 17:14
Signed-off-by: Michael Carroll <michael@openrobotics.org>

Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to add a full description for this PR. It only refers to another PR that doesn't explain anything about this one.

Are there plans to support models that are created or removed during the simulation? This limitation should be documented somewhere.

The PR looks good to me besides the comments below 👍🏽

Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
mjcarroll added 2 commits May 10, 2022 08:50
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@codecov
Copy link

codecov bot commented May 17, 2022

Codecov Report

Merging #1327 (e324b12) into main (9370793) will not change coverage.
The diff coverage is n/a.

❗ Current head e324b12 differs from pull request most recent head b5f6bc8. Consider uploading reports for the commit b5f6bc8 to get more accurate results

@@           Coverage Diff           @@
##             main    #1327   +/-   ##
=======================================
  Coverage   35.01%   35.01%           
=======================================
  Files          44       44           
  Lines        2356     2356           
=======================================
  Hits          825      825           
  Misses       1531     1531           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9370793...b5f6bc8. Read the comment docs.

@chapulina
Copy link
Contributor

I believe all the CI failures are pre-existing

@mjcarroll mjcarroll changed the title Reset physics Implement reset interface in the physics system May 17, 2022
@mjcarroll mjcarroll merged commit 40d97e9 into main May 17, 2022
@mjcarroll mjcarroll deleted the reset_physics branch May 17, 2022 17:59
@j-rivero j-rivero mentioned this pull request Sep 16, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants