Logs a warning if a buoyancy mode is not clearly specified. #1307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had originally started this branch to fix #1305. Turns out that #1305 was not actually a problem, still I decided to take the opportunity to imporve the logging so that if a user fails to specify `<uniform_fluid_density>` or `<graded_density>` then the user will be warned. Furthermore, I add a test for graded density mode that shows that #1305 is not an issue. Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## ign-gazebo6 #1307 +/- ##
===============================================
- Coverage 62.78% 62.77% -0.02%
===============================================
Files 299 299
Lines 24023 24028 +5
===============================================
Hits 15083 15083
- Misses 8940 8945 +5
Continue to review full report at Codecov.
|
caguero
reviewed
Feb 14, 2022
Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
caguero
approved these changes
Feb 17, 2022
|
I think a test introduced in this PR is failing on windows CI. Do you mind using |
arjo129
added a commit
that referenced
this pull request
Feb 28, 2022
See #1307 (comment) Buoyancy tests failing on windows. Disabling them to prevent noise. Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
7 tasks
|
See #1368 |
arjo129
added a commit
that referenced
this pull request
Mar 1, 2022
See #1307 (comment) Buoyancy tests failing on windows. Disabling them to prevent noise. Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
|
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-03-01-citadel-edifice-fortress/1313/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had originally started this branch to fix #1305. Turns out that #1305 was not actually a problem, still I decided to take the opportunity to imporve the logging so that if a user fails to specify
<uniform_fluid_density>or<graded_density>then the user will be warned. Furthermore, I add a test for graded density mode that shows that #1305 is not an issue.Signed-off-by: Arjo Chakravarty arjo@openrobotics.org