Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3 ➡️ 4 #1250

Merged
merged 3 commits into from
Dec 17, 2021
Merged

3 ➡️ 4 #1250

merged 3 commits into from
Dec 17, 2021

Conversation

chapulina
Copy link
Contributor

➡️ Forward port

Port ign-gazebo3 to ign-gazebo4

Branch comparison: ign-gazebo4...ign-gazebo3

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@github-actions github-actions bot added the 🔮 dome Ignition Dome label Dec 14, 2021
@codecov
Copy link

codecov bot commented Dec 14, 2021

Codecov Report

Merging #1250 (2058df9) into ign-gazebo4 (c473a08) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 2058df9 differs from pull request most recent head 3f7313a. Consider uploading reports for the commit 3f7313a to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           ign-gazebo4    #1250      +/-   ##
===============================================
- Coverage        66.41%   66.41%   -0.01%     
===============================================
  Files              250      250              
  Lines            19256    19258       +2     
===============================================
+ Hits             12789    12790       +1     
- Misses            6467     6468       +1     
Impacted Files Coverage Δ
src/SimulationRunner.cc 94.10% <100.00%> (+0.02%) ⬆️
src/Server.cc 84.33% <0.00%> (-0.61%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c473a08...3f7313a. Read the comment docs.

@chapulina chapulina merged commit 178b48d into ign-gazebo4 Dec 17, 2021
@chapulina chapulina deleted the chapulina/3_to_4 branch December 17, 2021 18:24
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-01-10/1228/1

@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-04-13-fortress-edifice/1367/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants