Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sdfString to copy constructor. #1185

Merged
merged 1 commit into from
Nov 11, 2021
Merged

Conversation

Mokosha
Copy link
Contributor

@Mokosha Mokosha commented Nov 10, 2021

🦟 Bug fix

Fixes #1182

@Mokosha Mokosha requested a review from chapulina as a code owner November 10, 2021 09:04
@github-actions github-actions bot added 🌱 garden Ignition Garden 🏯 fortress Ignition Fortress labels Nov 10, 2021
@ahcorde
Copy link
Contributor

ahcorde commented Nov 10, 2021

@Mokosha , Do you mind to sign the commit ?

@codecov
Copy link

codecov bot commented Nov 10, 2021

Codecov Report

Merging #1185 (443122c) into ign-gazebo6 (c7bd39f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           ign-gazebo6    #1185   +/-   ##
============================================
  Coverage        61.69%   61.69%           
============================================
  Files              259      259           
  Lines            20668    20669    +1     
============================================
+ Hits             12751    12752    +1     
  Misses            7917     7917           
Impacted Files Coverage Δ
src/ServerConfig.cc 90.36% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7bd39f...443122c. Read the comment docs.

Fixes gazebosim#1182

Signed-off-by: Pavel Krajcevski <krajcevski@google.com>
@chapulina chapulina merged commit d771a77 into gazebosim:ign-gazebo6 Nov 11, 2021
WilliamLewww pushed a commit to WilliamLewww/ign-gazebo that referenced this pull request Dec 7, 2021
Fixes gazebosim#1182

Signed-off-by: Pavel Krajcevski <krajcevski@google.com>
Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress 🌱 garden Ignition Garden
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SDF String not copied as part of server config copy constructor.
3 participants