Update Entity Id create offset on GUI side #1145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
adlarkin
approved these changes
Oct 26, 2021
chapulina
approved these changes
Oct 26, 2021
Codecov Report
@@ Coverage Diff @@
## ign-gazebo6 #1145 +/- ##
===============================================
- Coverage 63.84% 63.73% -0.12%
===============================================
Files 256 256
Lines 20077 20116 +39
===============================================
+ Hits 12819 12820 +1
- Misses 7258 7296 +38
Continue to review full report at Codecov.
|
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ian Chen ichen@osrfoundation.org
🦟 Bug fix
Summary
It was found that several GUI plugins in ign-gazebo casts
Entitytype to either 32 bit signed / unsigned integers so having an offset value of max 64 bit int / 4.0 causes issues with other GUI plugins, e.g. Component Inspector would not display the entity Id correctly and entity selection does not work.We will be fixing the 32 bit vs 64 bit int data type issue found in other GUI plugins separately. However, the main problem is found in entity selection. It gets the Entity Id through
ignition::rendering::Node'sUserDatacall which takes astd::variantobject that currently does not support 64 bit ints. Adding support for this breaks ABI so that'll need to be done in ign-rendering7 / Garden.This PR is a workaround for Fortress which sets the Entity Create offset to a value that can be represented using a 32 bit int.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge