Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality to add entities via the entity tree #1101

Merged
merged 10 commits into from
Nov 8, 2021

Conversation

mjcarroll
Copy link
Contributor

🎉 New feature

Summary

Put an "Insert Entity" button in the header of the entity tree.

image

Test it

Open gazebo with the EntityTree loaded. Click the "plus" button in the upper right and add entities.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll mjcarroll requested a review from chapulina as a code owner October 11, 2021 19:36
@github-actions github-actions bot added 🌱 garden Ignition Garden 🏯 fortress Ignition Fortress labels Oct 11, 2021
@nkoenig nkoenig self-requested a review October 11, 2021 20:05
@chapulina chapulina added the GUI Gazebo's graphical interface (not pure Ignition GUI) label Oct 11, 2021
@codecov
Copy link

codecov bot commented Oct 22, 2021

Codecov Report

Merging #1101 (e2a3516) into ign-gazebo6 (827fc3f) will increase coverage by 0.10%.
The diff coverage is 53.84%.

❗ Current head e2a3516 differs from pull request most recent head 025108f. Consider uploading reports for the commit 025108f to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           ign-gazebo6    #1101      +/-   ##
===============================================
+ Coverage        62.16%   62.27%   +0.10%     
===============================================
  Files              256      257       +1     
  Lines            20395    20440      +45     
===============================================
+ Hits             12679    12728      +49     
+ Misses            7716     7712       -4     
Impacted Files Coverage Δ
src/gui/plugins/entity_tree/EntityTree.cc 8.06% <0.00%> (-0.95%) ⬇️
src/gui/plugins/entity_tree/EntityTree.hh 100.00% <ø> (ø)
src/gui/plugins/lights/Lights.cc 47.05% <0.00%> (+20.39%) ⬆️
src/gui/plugins/shapes/Shapes.cc 52.63% <0.00%> (+27.63%) ⬆️
src/Primitives.cc 92.45% <92.45%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 827fc3f...025108f. Read the comment docs.

@nkoenig
Copy link
Contributor

nkoenig commented Oct 25, 2021

I think @jennuine implemented the ability to drag-drop a mesh file into the GUI in order to create a model. Would it be possible to have the Mesh menu button open a file-dialog so that the user can select a mesh to add?

nkoenig and others added 4 commits October 26, 2021 15:32
Signed-off-by: Nate Koenig <nate@openrobotics.org>

Co-authored-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll
Copy link
Contributor Author

I think @jennuine implemented the ability to drag-drop a mesh file into the GUI in order to create a model. Would it be possible to have the Mesh menu button open a file-dialog so that the user can select a mesh to add?

Done in ba1092b

Signed-off-by: Michael Carroll <michael@openrobotics.org>
Copy link
Contributor

@nkoenig nkoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works great

Signed-off-by: Nate Koenig <nate@openrobotics.org>
@nkoenig nkoenig merged commit c36d4aa into ign-gazebo6 Nov 8, 2021
@nkoenig nkoenig deleted the mjcarroll/entity_tree_add_button branch November 8, 2021 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress 🌱 garden Ignition Garden GUI Gazebo's graphical interface (not pure Ignition GUI)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants