Prevent crash when using <specular> workflow PBR material

[iche033]

Signed-off-by: Ian Chen ichen@osrfoundation.org

🦟 Bug fix

Fixes #1038

Summary

The PR prevents a crash when <material><pbr><specular> is specified in the SDF, and expanded the error msg. It will still try to render the material using the metal workflow but without metalness and roughness settings.

To test, try changing a model with PBR material to use the specular workflow, i.e. change <metal> to <specular> or just add <pbr><specular></specular></pbr> to <material> in any model, and ignition gazebo will crash without these changes.

Checklist

• Signed all commits for DCO
• Added tests
• Updated documentation (as needed)
• Updated migration guide (as needed)
• codecheck passed (See contributing)
• All tests passed (See test coverage)
• While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

[Kakcalu13]

Silly question,

I downloaded Citadel through apt. Once this merged, would this update apt automatically or do I need to use through github?

[chapulina]

Once this merged, would this update apt automatically or do I need to use through github?

It will be available through apt when we make the next release from the ign-gazebo3 branch. Keep an eye on the tags for 3.x. You can also subscribe to notifications.