Skip to content

Commit

Permalink
Added code suggestions
Browse files Browse the repository at this point in the history
Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
  • Loading branch information
WilliamLewww committed Nov 30, 2021
1 parent 06e5ec4 commit 507320f
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
6 changes: 2 additions & 4 deletions src/systems/light_controller/LightController.cc
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (C) 2019 Open Source Robotics Foundation
* Copyright (C) 2021 Open Source Robotics Foundation
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -45,7 +45,7 @@ class ignition::gazebo::systems::LightControllerPrivate
_a.type() == _b.type() &&
_a.name() == _b.name() &&
math::equal(
_a.diffuse().a(), _b.diffuse().a(), 1e-6f) &&
_a.diffuse().a(), _b.diffuse().a(), 1e-6f) &&
math::equal(
_a.diffuse().r(), _b.diffuse().r(), 1e-6f) &&
math::equal(
Expand Down Expand Up @@ -285,8 +285,6 @@ void LightControllerPrivate::LightCallback(
}
}



this->isUpdateRequired = true;
}

Expand Down
2 changes: 1 addition & 1 deletion src/systems/light_controller/LightController.hh
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (C) 2019 Open Source Robotics Foundation
* Copyright (C) 2021 Open Source Robotics Foundation
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down
2 changes: 2 additions & 0 deletions src/systems/user_commands/UserCommands.cc
Original file line number Diff line number Diff line change
Expand Up @@ -443,6 +443,8 @@ class ignition::gazebo::systems::UserCommandsPrivate
/// \return True if successful.
public: bool LightService(const msgs::Light &_req, msgs::Boolean &_res);

/// \brief Callback for light subscription
/// \param[in] _msg Light message
public: void OnCmdLight(const msgs::Light &_msg);

/// \brief Callback for pose service
Expand Down

0 comments on commit 507320f

Please sign in to comment.