Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump in edifice: ign-msgs7 #75

Merged
merged 1 commit into from
Jan 12, 2021
Merged

Bump in edifice: ign-msgs7 #75

merged 1 commit into from
Jan 12, 2021

Conversation

chapulina
Copy link
Contributor

@chapulina
Bump in edifice: ign-msgs7
2d54bb9 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina requested a review from iche033 as a code owner January 11, 2021 23:16
@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label Jan 11, 2021
@chapulina chapulina mentioned this pull request Jan 11, 2021
Merged
@chapulina
Copy link
Contributor Author

Actions CI needs to wait for the ign-transport10 nightlies that will be built tonight against ign-msgs7

I expect all others to build now.

@codecov
Copy link

codecov bot commented Jan 12, 2021 •
edited
Loading

Codecov Report

Merging #75 (2d54bb9) into main (f27e234) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #75   +/-   ##
=======================================
  Coverage   76.26%   76.26%           
=======================================
  Files          23       23           
  Lines        2321     2321           
=======================================
  Hits         1770     1770           
  Misses        551      551

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f27e234...2d54bb9. Read the comment docs.

@chapulina
Copy link
Contributor Author

There are lots of test failures on Windows and macOS, but I think most of those should be addressed by PRs that are pending a forward-port. So merging.

@chapulina chapulina merged commit 0e1f315 into main Jan 12, 2021
@chapulina chapulina deleted the bump_edifice_ign-msgs branch January 12, 2021 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkoenig nkoenig nkoenig approved these changes

@iche033 iche033 Awaiting requested review from iche033 iche033 is a code owner

Assignees
No one assigned
Labels
🏢 edifice Ignition Edifice
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chapulina @nkoenig