Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set custom projection values from sdf #314

Merged
merged 7 commits into from
Feb 14, 2023
Merged

Set custom projection values from sdf #314

merged 7 commits into from
Feb 14, 2023

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Feb 9, 2023

🎉 New feature

Summary

Related comment: #293 (comment)

This PR allows users to specify custom camera projection using the <projection> values from SDF (in addition to <instrinscs>, see #293).

Also bumped sdformat dep version as it need gazebosim/sdformat#1203

Test it

Run the INTEGRATION_camera test

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <ichen@openrobotics.org>
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Feb 9, 2023
@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Merging #314 (9f7fb14) into gz-sensors7 (06457f7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 9f7fb14 differs from pull request most recent head b6b4187. Consider uploading reports for the commit b6b4187 to get more accurate results

@@             Coverage Diff              @@
##           gz-sensors7     #314   +/-   ##
============================================
  Coverage        69.80%   69.80%           
============================================
  Files               36       36           
  Lines             3888     3898   +10     
============================================
+ Hits              2714     2721    +7     
- Misses            1174     1177    +3     
Impacted Files Coverage Δ
src/CameraSensor.cc 80.42% <100.00%> (+0.53%) ⬆️
src/Sensor.cc 89.83% <0.00%> (-1.61%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

iche033 and others added 4 commits February 8, 2023 17:12
Signed-off-by: Ian Chen <ichen@openrobotics.org>
Signed-off-by: Ian Chen <ichen@openrobotics.org>
iche033 and others added 2 commits February 10, 2023 12:09
Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033 iche033 merged commit d6568aa into gz-sensors7 Feb 14, 2023
@iche033 iche033 deleted the set_projection branch February 14, 2023 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants