Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove todo in gpu ray test #949

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Remove todo in gpu ray test #949

merged 1 commit into from
Jan 2, 2024

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Jan 2, 2024

🦟 Bug fix

Summary

Remove code as mentioned in the todo note now that the OgreHeightmap::Destroy function is available. The test should not crash.

To run the test in your local colcon workspace:

GZ_ENGINE_TO_TEST=ogre2 ./build/gz-rendering8/bin/INTEGRATION_gpu_rays

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <ichen@openrobotics.org>
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Jan 2, 2024
Copy link

codecov bot commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (93c2785) 75.54% compared to head (f061f5f) 75.54%.

Additional details and impacted files
@@              Coverage Diff               @@
##           gz-rendering8     #949   +/-   ##
==============================================
  Coverage          75.54%   75.54%           
==============================================
  Files                177      177           
  Lines              16887    16887           
==============================================
  Hits               12758    12758           
  Misses              4129     4129           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iche033 iche033 merged commit 5cad5c0 into gz-rendering8 Jan 2, 2024
7 checks passed
@iche033 iche033 deleted the remove_todo_test branch January 2, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants