Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence CMake policy CMP0072 #528

Merged
merged 1 commit into from
Jan 6, 2022
Merged

Conversation

chapulina
Copy link
Contributor

🦟 Bug fix

Summary

Calling cmake_policy is complicated in this situation because the find_package call is made in a different scope, within ign_find_package. Setting the variable directly does the trick though. See #360 (comment).

This doesn't solve the problem for downstream projects though. I didn't find a way of passing variables to ignition-component-config.cmake.in.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina requested a review from iche033 as a code owner January 6, 2022 17:49
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Jan 6, 2022
@chapulina chapulina mentioned this pull request Jan 6, 2022
@codecov
Copy link

codecov bot commented Jan 6, 2022

Codecov Report

Merging #528 (aac778b) into ign-rendering3 (e4ad6da) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-rendering3     #528   +/-   ##
===============================================
  Coverage           53.35%   53.35%           
===============================================
  Files                 131      131           
  Lines               12035    12035           
===============================================
  Hits                 6421     6421           
  Misses               5614     5614           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4ad6da...aac778b. Read the comment docs.

Copy link
Contributor

@iche033 iche033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@chapulina chapulina merged commit 01343da into ign-rendering3 Jan 6, 2022
@chapulina chapulina deleted the chapulina/3/CMP0072 branch January 6, 2022 19:32
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-03-01-citadel-edifice-fortress/1313/1

@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-03-25-fortress-edifice-citadel/1343/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants