Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple collisions per link in bullet-featherstone #505

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Apr 10, 2023

🦟 Bug fix

Only the first collision element in a link was created when using bullet-featherstone. This PR adds each collision shape as a childShape to the bullet collider.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Nate Koenig <natekoenig@gmail.com>
@mjcarroll
Copy link
Contributor

LGTM with green CI

@codecov
Copy link

codecov bot commented Apr 10, 2023

Codecov Report

Merging #505 (5384d1b) into gz-physics6 (35d02fe) will increase coverage by 0.00%.
The diff coverage is 53.84%.

❗ Current head 5384d1b differs from pull request most recent head a34d068. Consider uploading reports for the commit a34d068 to get more accurate results

@@             Coverage Diff              @@
##           gz-physics6     #505   +/-   ##
============================================
  Coverage        75.50%   75.51%           
============================================
  Files              142      142           
  Lines             7173     7175    +2     
============================================
+ Hits              5416     5418    +2     
  Misses            1757     1757           
Impacted Files Coverage Δ
bullet-featherstone/src/SDFFeatures.cc 71.97% <53.84%> (+0.11%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nkoenig nkoenig merged commit 3cdb4af into gz-physics6 Apr 11, 2023
@nkoenig nkoenig deleted the nkoenig/bullet-multiple-collisions branch April 11, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants