Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate common tests part1 #448

Merged
merged 2 commits into from
Nov 22, 2022

Conversation

scpeters
Copy link
Member

🎉 New feature

Deduplicate some code in common tests

Summary

This is a prototype of some deduplication of code in the common tests:

  • adf1147: reference feature lists recursively to avoid repeating feature names
  • af8e428: add templatized helper function for requesting engine and loading an empty world and replace duplicate code in all test cases. Some additional helper functions could be added to further reduce the code duplication.

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Nov 12, 2022
@codecov
Copy link

codecov bot commented Nov 12, 2022

Codecov Report

Merging #448 (af8e428) into gz-physics6 (619625d) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           gz-physics6     #448   +/-   ##
============================================
  Coverage        75.73%   75.73%           
============================================
  Files              140      140           
  Lines             7039     7039           
============================================
  Hits              5331     5331           
  Misses            1708     1708           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@scpeters scpeters changed the title Scpeters/deduplicate common tests part1 Deduplicate common tests part1 Nov 12, 2022
@scpeters scpeters marked this pull request as ready for review November 22, 2022 00:45
@scpeters scpeters requested a review from mxgrey as a code owner November 22, 2022 00:45
@scpeters scpeters merged commit 48acd7a into gz-physics6 Nov 22, 2022
@scpeters scpeters deleted the scpeters/deduplicate_common_tests_part1 branch November 22, 2022 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants