Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bullet-featherstone: fix ellipsoid on focal #439

Merged
merged 2 commits into from
Oct 14, 2022
Merged

Bullet-featherstone: fix ellipsoid on focal #439

merged 2 commits into from
Oct 14, 2022

Conversation

mjcarroll
Copy link
Contributor

🦟 Bug fix

Summary

Attempt to diagnose the ellipsoid failure on focal CI.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@mjcarroll
Add some debug output for focal
ed66bbe 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll mjcarroll changed the title Add some debug output for focal Bullet-featherstone: fix ellipsoid on focal Oct 14, 2022
@mjcarroll mjcarroll marked this pull request as ready for review October 14, 2022 21:08
@mjcarroll
Comment out flaky test
97d5db7 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll mjcarroll force-pushed the mjcarroll/add-bullet-featherstone/fix_ellipsoid branch from fbdcd47 to 97d5db7 Compare October 14, 2022 21:46
@mjcarroll mjcarroll merged commit d7fd295 into add-bullet-featherstone Oct 14, 2022
@mjcarroll mjcarroll deleted the mjcarroll/add-bullet-featherstone/fix_ellipsoid branch October 14, 2022 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

@azeey azeey Awaiting requested review from azeey

@mxgrey mxgrey Awaiting requested review from mxgrey

@scpeters scpeters Awaiting requested review from scpeters

Assignees
No one assigned
Labels
None yet
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjcarroll @ahcorde