Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bullet-featherstone: Apply external forces and torques #438

Conversation

mjcarroll
Copy link
Contributor

@mjcarroll mjcarroll commented Oct 11, 2022

🎉 New feature

Closes #

Summary

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@mjcarroll mjcarroll changed the title @wip Bullet-featherstone: Apply external forces and torques Oct 11, 2022
Base automatically changed from ahcorde/add-bullet-featherstone/contacts to add-bullet-featherstone October 12, 2022 21:14
@ahcorde ahcorde marked this pull request as ready for review October 13, 2022 11:09
mjcarroll and others added 4 commits October 13, 2022 09:08
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll mjcarroll force-pushed the mjcarroll/add-bullet-featherstone/apply-force branch from 9a69aeb to f232bda Compare October 13, 2022 14:08
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Merging #438 (da1d494) into add-bullet-featherstone (9e7af39) will increase coverage by 0.80%.
The diff coverage is 62.70%.

❗ Current head da1d494 differs from pull request most recent head 7a4adef. Consider uploading reports for the commit 7a4adef to get more accurate results

@@                     Coverage Diff                     @@
##           add-bullet-featherstone     #438      +/-   ##
===========================================================
+ Coverage                    74.55%   75.36%   +0.80%     
===========================================================
  Files                          128      140      +12     
  Lines                         5628     7066    +1438     
===========================================================
+ Hits                          4196     5325    +1129     
- Misses                        1432     1741     +309     
Impacted Files Coverage Δ
bullet-featherstone/src/FreeGroupFeatures.cc 0.00% <0.00%> (ø)
bullet/src/JointFeatures.cc 0.00% <0.00%> (ø)
bullet/src/SDFFeatures.cc 51.03% <0.00%> (+5.97%) ⬆️
dartsim/src/SimulationFeatures.cc 93.44% <ø> (+3.27%) ⬆️
dartsim/src/SimulationFeatures.hh 100.00% <ø> (ø)
include/gz/physics/ForwardStep.hh 100.00% <ø> (ø)
include/gz/physics/FrameID.hh 100.00% <ø> (ø)
include/gz/physics/FrameSemantics.hh 100.00% <ø> (ø)
include/gz/physics/Geometry.hh 100.00% <ø> (ø)
include/gz/physics/detail/FrameSemantics.hh 95.91% <0.00%> (-4.09%) ⬇️
... and 38 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mjcarroll mjcarroll merged commit 04737e8 into add-bullet-featherstone Oct 13, 2022
@mjcarroll mjcarroll deleted the mjcarroll/add-bullet-featherstone/apply-force branch October 13, 2022 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants