Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added FreeGroupWorld Velocities and minor fixes #435

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Oct 7, 2022

Signed-off-by: ahcorde ahcorde@gmail.com

🎉 New feature

Summary

  • Added FreeGroupWorld Velocities and minor fixes
  • If there is no CMD commands then I don't attach the motor to move the joint, because this will block the joint.

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
…detachable_joints' into ahcorde/add-bullet-featherstone/contacts
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
* Refactor joint code

Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from mjcarroll October 7, 2022 11:24
@ahcorde ahcorde self-assigned this Oct 7, 2022
Signed-off-by: ahcorde <ahcorde@gmail.com>
@codecov
Copy link

codecov bot commented Oct 7, 2022

Codecov Report

Merging #435 (6ad294f) into add-bullet-featherstone (9e7af39) will increase coverage by 0.84%.
The diff coverage is 62.55%.

@@                     Coverage Diff                     @@
##           add-bullet-featherstone     #435      +/-   ##
===========================================================
+ Coverage                    74.55%   75.40%   +0.84%     
===========================================================
  Files                          128      139      +11     
  Lines                         5628     7025    +1397     
===========================================================
+ Hits                          4196     5297    +1101     
- Misses                        1432     1728     +296     
Impacted Files Coverage Δ
bullet-featherstone/src/FreeGroupFeatures.cc 0.00% <0.00%> (ø)
bullet/src/JointFeatures.cc 0.00% <0.00%> (ø)
bullet/src/SDFFeatures.cc 51.03% <0.00%> (+5.97%) ⬆️
dartsim/src/SimulationFeatures.cc 93.44% <ø> (+3.27%) ⬆️
dartsim/src/SimulationFeatures.hh 100.00% <ø> (ø)
include/gz/physics/ForwardStep.hh 100.00% <ø> (ø)
include/gz/physics/FrameID.hh 100.00% <ø> (ø)
include/gz/physics/FrameSemantics.hh 100.00% <ø> (ø)
include/gz/physics/Geometry.hh 100.00% <ø> (ø)
include/gz/physics/detail/FrameSemantics.hh 95.91% <0.00%> (-4.09%) ⬇️
... and 37 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Base automatically changed from ahcorde/add-bullet-featherstone/contacts to add-bullet-featherstone October 12, 2022 21:14
@mjcarroll mjcarroll merged commit ade8b92 into add-bullet-featherstone Oct 13, 2022
@mjcarroll mjcarroll deleted the ahcorde/add-bullet-featherstone/FreeGroupWorldVelocity branch October 13, 2022 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants