Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bullet featherstone: Added contacts and improved simulation tests #429

Merged

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Sep 29, 2022

Signed-off-by: ahcorde ahcorde@gmail.com

🎉 New feature

Summary

Bullet featherstone: Added contacts and improved simulation tests

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from mjcarroll September 29, 2022 15:35
@ahcorde ahcorde self-assigned this Sep 29, 2022
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Merging #429 (42cb522) into add-bullet-featherstone (a5b2f7d) will increase coverage by 5.19%.
The diff coverage is 85.93%.

❗ Current head 42cb522 differs from pull request most recent head 11b09e1. Consider uploading reports for the commit 11b09e1 to get more accurate results

@@                     Coverage Diff                     @@
##           add-bullet-featherstone     #429      +/-   ##
===========================================================
+ Coverage                    69.85%   75.05%   +5.19%     
===========================================================
  Files                          139      139              
  Lines                         6871     6975     +104     
===========================================================
+ Hits                          4800     5235     +435     
+ Misses                        2071     1740     -331     
Impacted Files Coverage Δ
bullet-featherstone/src/SDFFeatures.cc 70.78% <0.00%> (+7.07%) ⬆️
dartsim/src/SimulationFeatures.cc 93.44% <ø> (ø)
bullet-featherstone/src/KinematicsFeatures.cc 83.33% <73.68%> (-16.67%) ⬇️
bullet-featherstone/src/SimulationFeatures.cc 98.48% <96.55%> (+3.89%) ⬆️
bullet-featherstone/src/JointFeatures.cc 41.02% <97.72%> (+22.27%) ⬆️
bullet-featherstone/src/Base.hh 100.00% <100.00%> (ø)
bullet-featherstone/src/ShapeFeatures.cc 91.21% <100.00%> (+91.21%) ⬆️
dartsim/src/FreeGroupFeatures.cc 49.46% <0.00%> (-32.26%) ⬇️
dartsim/src/EntityManagementFeatures.cc 73.84% <0.00%> (-8.95%) ⬇️
include/gz/physics/detail/FrameSemantics.hh 95.91% <0.00%> (-4.09%) ⬇️
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

…detachable_joints' into ahcorde/add-bullet-featherstone/contacts
Base automatically changed from ahcorde/add-bullet-featherstone/detachable_joints to add-bullet-featherstone September 29, 2022 18:40
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
* Refactor joint code

Signed-off-by: ahcorde <ahcorde@gmail.com>
@mjcarroll mjcarroll merged commit 36e57a2 into add-bullet-featherstone Oct 12, 2022
@mjcarroll mjcarroll deleted the ahcorde/add-bullet-featherstone/contacts branch October 12, 2022 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants