Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bullet-featherstone mesh collisions #425

Merged
merged 3 commits into from
Sep 21, 2022

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Sep 20, 2022

Signed-off-by: ahcorde ahcorde@gmail.com

🦟 Bug fix

Summary

Meshes were not colliding with the static plane. This PR should fix this issue.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from mjcarroll September 20, 2022 21:37
@ahcorde ahcorde requested a review from azeey as a code owner September 20, 2022 21:37
@ahcorde ahcorde self-assigned this Sep 20, 2022
@codecov
Copy link

codecov bot commented Sep 20, 2022

Codecov Report

Merging #425 (1958ea4) into add-bullet-featherstone (1994480) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@                     Coverage Diff                     @@
##           add-bullet-featherstone     #425      +/-   ##
===========================================================
- Coverage                    70.14%   70.12%   -0.03%     
===========================================================
  Files                          139      139              
  Lines                         6843     6845       +2     
===========================================================
  Hits                          4800     4800              
- Misses                        2043     2045       +2     
Impacted Files Coverage Δ
bullet-featherstone/src/Base.hh 100.00% <ø> (ø)
bullet-featherstone/src/SDFFeatures.cc 67.50% <0.00%> (-0.32%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
@mjcarroll mjcarroll merged commit 3981fdb into add-bullet-featherstone Sep 21, 2022
@mjcarroll mjcarroll deleted the ahcorde/fix/mesh_collision branch September 21, 2022 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants