Bullet featherstone fix joint pose #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
…corde/add-bullet-featherstone/shapesFeatures
…corde/add-bullet-featherstone/shapesFeatures
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
…corde/add-bullet-featherstone/shapesFeatures
Signed-off-by: ahcorde <ahcorde@gmail.com>
…corde/add-bullet-featherstone/shapesFeatures
…corde/add-bullet-featherstone/shapesFeatures
* Improved joints in bullet featherstone Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
…rstone/shapesFeatures Signed-off-by: Michael Carroll <michael@openrobotics.org>
…corde/add-bullet-featherstone/fix_joints
|
|
…fix_joints' into ahcorde/add-bullet-featherstone/fix_joints
Base automatically changed from
ahcorde/add-bullet-featherstone/shapesFeatures
to
add-bullet-featherstone
September 16, 2022 17:55
…rstone/fix_joints
…rstone/fix_joints
…fix_joints' into ahcorde/add-bullet-featherstone/fix_joints
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Codecov Report
@@ Coverage Diff @@
## add-bullet-featherstone #418 +/- ##
===========================================================
- Coverage 74.55% 70.48% -4.08%
===========================================================
Files 128 139 +11
Lines 5628 6810 +1182
===========================================================
+ Hits 4196 4800 +604
- Misses 1432 2010 +578
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ahcorde ahcorde@gmail.com
🦟 Bug fix
Solved
Now I'm facing other issues. The constraints are not applied, for example angle limits are not working.
Summary
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.