Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GoogleTest to latest version #369

Merged
merged 7 commits into from
Jun 29, 2022
Merged

Update GoogleTest to latest version #369

merged 7 commits into from
Jun 29, 2022

Conversation

mjcarroll
Copy link
Contributor

Import latest version of GoogleTest from upstream and adjust build accordingly.

Tracking issue: gazebosim/gz-sim#1537

Signed-off-by: Michael Carroll michael@openrobotics.org

mjcarroll added 5 commits June 27, 2022 13:27
@mjcarroll
Remove old gtest version
b4e7c92 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll
Add new vendored Googletest version
62f4ca1 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll
CMake updates for new googletest version
0bd6fd2 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll
Test updates for new googletest version
7776dd6 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll
Remove unnecessary gtest_main functions
cacc9f8 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jun 28, 2022
@mjcarroll mjcarroll mentioned this pull request Jun 28, 2022
Closed
14 tasks
@codecov
Copy link

codecov bot commented Jun 28, 2022 •
edited
Loading

Codecov Report

Merging #369 (4704b7b) into main (265b31b) will not change coverage.
The diff coverage is n/a.

❗ Current head 4704b7b differs from pull request most recent head 73d7bac. Consider uploading reports for the commit 73d7bac to get more accurate results

@@           Coverage Diff           @@
##             main     #369   +/-   ##
=======================================
  Coverage   74.55%   74.55%           
=======================================
  Files         128      128           
  Lines        5628     5628           
=======================================
  Hits         4196     4196           
  Misses       1432     1432

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 265b31b...73d7bac. Read the comment docs.

ahcorde
ahcorde approved these changes Jun 28, 2022
View reviewed changes
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a minor comment

mjcarroll and others added 2 commits June 28, 2022 11:23
@mjcarroll @ahcorde
Update test/CMakeLists.txt
e9e377c 
Signed-off-by: Michael Carroll <michael@openrobotics.org>

Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@ahcorde
Merge branch 'main' into bump_gtest
73d7bac
@mjcarroll mjcarroll merged commit fac0793 into main Jun 29, 2022
@mjcarroll mjcarroll deleted the bump_gtest branch June 29, 2022 15:26
@mjcarroll mjcarroll mentioned this pull request Jul 6, 2022
Merged
9 tasks
@chapulina chapulina added the tests Broken or missing tests / testing infra label Jul 6, 2022
This was referenced Sep 22, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

@azeey azeey Awaiting requested review from azeey azeey is a code owner

@mxgrey mxgrey Awaiting requested review from mxgrey

@scpeters scpeters Awaiting requested review from scpeters scpeters is a code owner

Assignees
No one assigned
Labels
🌱 garden Ignition Garden tests Broken or missing tests / testing infra
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mjcarroll @ahcorde @chapulina