Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bullet: Added collision shape to Capsule and Ellipsoid #350

Merged
merged 1 commit into from
Jun 15, 2022

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Jun 2, 2022

🎉 New feature

Summary

Added collision shapes to Capsule and Ellipsoid

bullet_collision

I didn't add test because it's a little bit messy. we need to refactor tests

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from mjcarroll June 2, 2022 08:26
@ahcorde ahcorde self-assigned this Jun 2, 2022
@ahcorde ahcorde requested review from azeey, mxgrey and scpeters as code owners June 2, 2022 08:26
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jun 2, 2022
@ahcorde ahcorde added the Bullet Bullet engine label Jun 2, 2022
@codecov
Copy link

codecov bot commented Jun 2, 2022

Codecov Report

Merging #350 (213c2e5) into main (0cf0e89) will decrease coverage by 21.89%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##             main     #350       +/-   ##
===========================================
- Coverage   97.36%   75.46%   -21.90%     
===========================================
  Files          69      128       +59     
  Lines        1328     5552     +4224     
===========================================
+ Hits         1293     4190     +2897     
- Misses         35     1362     +1327     
Impacted Files Coverage Δ
bullet/src/SDFFeatures.cc 45.06% <0.00%> (ø)
...ll/include/ignition/physics6/gz/physics/Feature.hh
...clude/ignition/physics6/gz/physics/detail/World.hh
...nclude/ignition/physics6/gz/physics/SpecifyData.hh
...ition/physics6/gz/physics/detail/EllipsoidShape.hh
...gnition/physics6/gz/physics/detail/CapsuleShape.hh
...l/include/ignition/physics6/gz/physics/BoxShape.hh
...ude/ignition/physics6/gz/physics/FrameSemantics.hh
...on/physics6/gz/physics/heightmap/HeightmapShape.hh
...ysics6/gz/physics/detail/OperateOnSpecifiedData.hh
... and 188 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cf0e89...213c2e5. Read the comment docs.

@mjcarroll
Copy link
Contributor

Intent is to bump up coverage via common testing, so I think this is okay for now.

@mjcarroll mjcarroll merged commit a7f3935 into main Jun 15, 2022
@mjcarroll mjcarroll deleted the ahcorde/bullet/capsule_ellipsoid branch June 15, 2022 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bullet Bullet engine 🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants