Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3 ➡️ 4 #308

Merged
merged 8 commits into from
Nov 11, 2021
Merged

3 ➡️ 4 #308

merged 8 commits into from
Nov 11, 2021

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Nov 11, 2021

➡️ Forward port

Port ign-physics3 to ign-physics4

Branch comparison: ign-physics4...ign-physics3

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

peci1 and others added 8 commits October 28, 2021 11:53
Adds support for registering callbacks that modify properties of all contacts generated by the dynamics engine. Example implementation for DART is provided.

Signed-off-by: Martin Pecka <peckama2@fel.cvut.cz>
Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org>
* Added DART feature for setting joint limits dynamically.

Signed-off-by: Martin Pecka <peckama2@fel.cvut.cz>

* Make code compatible with older DART release (this commit can be reverted once newer DART is out).

Signed-off-by: Martin Pecka <peckama2@fel.cvut.cz>

* Updated the number of models for test.

Signed-off-by: Martin Pecka <peckama2@fel.cvut.cz>

* Apply suggestions from code review

Signed-off-by: Martin Pecka <peckama2@fel.cvut.cz>

Co-authored-by: Addisu Z. Taddese <addisu@gmail.com>

* Fixed issues from review.

Signed-off-by: Martin Pecka <peckama2@fel.cvut.cz>

* Accomodate DART 6.9

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>

Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org>
Co-authored-by: Addisu Z. Taddese <addisu@gmail.com>
Co-authored-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
The header template provided by ign-cmake is used instead.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label Nov 11, 2021
@codecov
Copy link

codecov bot commented Nov 11, 2021

Codecov Report

Merging #308 (4e5811f) into ign-physics4 (b9b99f9) will increase coverage by 0.19%.
The diff coverage is 88.18%.

Impacted file tree graph

@@               Coverage Diff                @@
##           ign-physics4     #308      +/-   ##
================================================
+ Coverage         75.65%   75.84%   +0.19%     
================================================
  Files               125      127       +2     
  Lines              5627     5734     +107     
================================================
+ Hits               4257     4349      +92     
- Misses             1370     1385      +15     
Impacted Files Coverage Δ
dartsim/src/SimulationFeatures.cc 85.40% <85.00%> (-5.83%) ⬇️
dartsim/src/SimulationFeatures.hh 100.00% <100.00%> (ø)
...clude/ignition/physics/detail/ContactProperties.hh 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9b99f9...4e5811f. Read the comment docs.

@chapulina chapulina merged commit ab938e7 into ign-physics4 Nov 11, 2021
@chapulina chapulina deleted the azeey/3_to_4 branch November 11, 2021 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏢 edifice Ignition Edifice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants