-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3 ➡️ 4 #308
Merged
Merged
3 ➡️ 4 #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for registering callbacks that modify properties of all contacts generated by the dynamics engine. Example implementation for DART is provided. Signed-off-by: Martin Pecka <peckama2@fel.cvut.cz> Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org>
* Added DART feature for setting joint limits dynamically. Signed-off-by: Martin Pecka <peckama2@fel.cvut.cz> * Make code compatible with older DART release (this commit can be reverted once newer DART is out). Signed-off-by: Martin Pecka <peckama2@fel.cvut.cz> * Updated the number of models for test. Signed-off-by: Martin Pecka <peckama2@fel.cvut.cz> * Apply suggestions from code review Signed-off-by: Martin Pecka <peckama2@fel.cvut.cz> Co-authored-by: Addisu Z. Taddese <addisu@gmail.com> * Fixed issues from review. Signed-off-by: Martin Pecka <peckama2@fel.cvut.cz> * Accomodate DART 6.9 Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org> Co-authored-by: Addisu Z. Taddese <addisu@gmail.com> Co-authored-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
The header template provided by ign-cmake is used instead. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## ign-physics4 #308 +/- ##
================================================
+ Coverage 75.65% 75.84% +0.19%
================================================
Files 125 127 +2
Lines 5627 5734 +107
================================================
+ Hits 4257 4349 +92
- Misses 1370 1385 +15
Continue to review full report at Codecov.
|
chapulina
approved these changes
Nov 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
➡️ Forward port
Port ign-physics3 to ign-physics4
Branch comparison: ign-physics4...ign-physics3
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)