-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename CanonicalLink to RootLink #234
Conversation
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look OK to me. I'll let @scpeters do one last final pass since I'm still pretty new to ign-physics
.
Should we add a note to the migration guide about this change so that other users who have a plugin that implements the FreeGroup
feature know what updates to make to reflect this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, just need a migration guide entry
I might make a suggestion about the naming:
If |
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
|
Ubuntu CI failed due to infra issues. |
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
🦟 Bug fix
Fixes #233
Summary
See #233 for context.
This deprecates the end-user facing function
CanonicalLink
adds a new one calledUnconstrainedLink
.Note: While the changes in this PR won't break downstream users of ign-physics, it will break any physics plugins the implement the
FreeGroup
feature.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge