API documentation common Get* feature #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: anindex <an.thai.le97@gmail.com>
Signed-off-by: anindex <an.thai.le97@gmail.com>
Signed-off-by: anindex <an.thai.le97@gmail.com>
Signed-off-by: anindex <an.thai.le97@gmail.com>
Signed-off-by: anindex <an.thai.le97@gmail.com>
Signed-off-by: anindex <an.thai.le97@gmail.com>
Signed-off-by: anindex <an.thai.le97@gmail.com>
Signed-off-by: anindex <an.thai.le97@gmail.com>
Signed-off-by: anindex <an.thai.le97@gmail.com>
Signed-off-by: anindex <an.thai.le97@gmail.com>
claireyywang
suggested changes
Nov 19, 2020
There was a problem hiding this comment.
Looks good in general. I just had some minor comments about format and wording. I noticed you borrowed some definition and wording from existing API documentation, which is helpful but not great reference. It'd be better for our new API documentation to improve based on that effort rather than keeping it.
scpeters
reviewed
Nov 19, 2020
Signed-off-by: anindex <an.thai.le97@gmail.com>
claireyywang
approved these changes
Dec 2, 2020
claireyywang
added a commit
that referenced
this pull request
Jan 7, 2021
* GetEngineInfo docs Signed-off-by: anindex <an.thai.le97@gmail.com> * GetWorldFromEngine docs Signed-off-by: anindex <an.thai.le97@gmail.com> * GetModelFromWorld docs Signed-off-by: anindex <an.thai.le97@gmail.com> * GetLinkFromModel docs Signed-off-by: anindex <an.thai.le97@gmail.com> * GetJointFromModel docs Signed-off-by: anindex <an.thai.le97@gmail.com> * GetShapeFromLink docs Signed-off-by: anindex <an.thai.le97@gmail.com> * GetJoint* docs Signed-off-by: anindex <an.thai.le97@gmail.com> * GetShape* docs Signed-off-by: anindex <an.thai.le97@gmail.com> * GetShapeFriction docs Signed-off-by: anindex <an.thai.le97@gmail.com> * Get bounding box docs Signed-off-by: anindex <an.thai.le97@gmail.com> * Refine docs Signed-off-by: anindex <an.thai.le97@gmail.com> Co-authored-by: anindex <an.thai.le97@gmail.com> Co-authored-by: Claire Wang <22240514+claireyywang@users.noreply.github.com>
claireyywang
added a commit
that referenced
this pull request
Jan 7, 2021
* GetEngineInfo docs Signed-off-by: anindex <an.thai.le97@gmail.com> * GetWorldFromEngine docs Signed-off-by: anindex <an.thai.le97@gmail.com> * GetModelFromWorld docs Signed-off-by: anindex <an.thai.le97@gmail.com> * GetLinkFromModel docs Signed-off-by: anindex <an.thai.le97@gmail.com> * GetJointFromModel docs Signed-off-by: anindex <an.thai.le97@gmail.com> * GetShapeFromLink docs Signed-off-by: anindex <an.thai.le97@gmail.com> * GetJoint* docs Signed-off-by: anindex <an.thai.le97@gmail.com> * GetShape* docs Signed-off-by: anindex <an.thai.le97@gmail.com> * GetShapeFriction docs Signed-off-by: anindex <an.thai.le97@gmail.com> * Get bounding box docs Signed-off-by: anindex <an.thai.le97@gmail.com> * Refine docs Signed-off-by: anindex <an.thai.le97@gmail.com> Co-authored-by: anindex <an.thai.le97@gmail.com> Co-authored-by: Claire Wang <22240514+claireyywang@users.noreply.github.com>
chapulina
pushed a commit
that referenced
this pull request
Jan 21, 2021
* GetEngineInfo docs Signed-off-by: anindex <an.thai.le97@gmail.com> * GetWorldFromEngine docs Signed-off-by: anindex <an.thai.le97@gmail.com> * GetModelFromWorld docs Signed-off-by: anindex <an.thai.le97@gmail.com> * GetLinkFromModel docs Signed-off-by: anindex <an.thai.le97@gmail.com> * GetJointFromModel docs Signed-off-by: anindex <an.thai.le97@gmail.com> * GetShapeFromLink docs Signed-off-by: anindex <an.thai.le97@gmail.com> * GetJoint* docs Signed-off-by: anindex <an.thai.le97@gmail.com> * GetShape* docs Signed-off-by: anindex <an.thai.le97@gmail.com> * GetShapeFriction docs Signed-off-by: anindex <an.thai.le97@gmail.com> * Get bounding box docs Signed-off-by: anindex <an.thai.le97@gmail.com> * Refine docs Signed-off-by: anindex <an.thai.le97@gmail.com> Co-authored-by: anindex <an.thai.le97@gmail.com> Co-authored-by: Claire Wang <22240514+claireyywang@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From issue #9