Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial implement a custom feature #131

Merged

Conversation

anindex
Copy link
Contributor

@anindex anindex commented Oct 18, 2020

Signed-off-by: anindex an.thai.le97@gmail.com

Signed-off-by: anindex <an.thai.le97@gmail.com>
@anindex anindex requested a review from mxgrey as a code owner October 18, 2020 12:49
@chapulina chapulina added the documentation Improvements or additions to documentation label Oct 19, 2020
Copy link
Contributor

@claireyywang claireyywang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some nitpicks, the rest LGTM

Signed-off-by: anindex <an.thai.le97@gmail.com>
Signed-off-by: anindex <an.thai.le97@gmail.com>
Copy link
Contributor

@claireyywang claireyywang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@claireyywang claireyywang merged commit 5e06f4d into gazebosim:main Oct 29, 2020
claireyywang added a commit that referenced this pull request Jan 7, 2021
* Initial draft for implementing a custom feature
* Update tutorial name in front page
* Change headline names for consistency
* Revised some nitpicks
* Add folder structure for feature

Co-authored-by: anindex <an.thai.le97@gmail.com>
Co-authored-by: Claire Wang <22240514+claireyywang@users.noreply.github.com>
claireyywang added a commit that referenced this pull request Jan 7, 2021
* Initial draft for implementing a custom feature
* Update tutorial name in front page
* Change headline names for consistency
* Revised some nitpicks
* Add folder structure for feature

Co-authored-by: anindex <an.thai.le97@gmail.com>
Co-authored-by: Claire Wang <22240514+claireyywang@users.noreply.github.com>
chapulina pushed a commit that referenced this pull request Jan 21, 2021
* Initial draft for implementing a custom feature
* Update tutorial name in front page
* Change headline names for consistency
* Revised some nitpicks
* Add folder structure for feature

Co-authored-by: anindex <an.thai.le97@gmail.com>
Co-authored-by: Claire Wang <22240514+claireyywang@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants