Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge gz-math7 ➡️ main #570

Merged
merged 20 commits into from
Nov 14, 2023
Merged

Merge gz-math7 ➡️ main #570

merged 20 commits into from
Nov 14, 2023

Conversation

scpeters
Copy link
Member

➡️ Forward port

Port gz-math7 ➡️ main

Branch comparison: main...gz-math7

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

azeey and others added 20 commits April 14, 2023 12:53
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Henrique-BO <henrique.barrosoliveira@usp.br>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
… models (#486)

* Class ignition::math::MecanumDriveOdometryPrivate to handle Mecanum wheels odometry

Signed-off-by: danilo_gsch <danilo_gsch@hotmail.com>

* Update include/ignition/math/MecanumDriveOdometry.hh

Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: danilo_gsch <danilo_gsch@hotmail.com>

* Update include/ignition/math/MecanumDriveOdometry.hh

Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: danilo_gsch <danilo_gsch@hotmail.com>

* Update include/ignition/math/MecanumDriveOdometry.hh

Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: danilo_gsch <danilo_gsch@hotmail.com>

* Update src/MecanumDriveOdometry.cc

Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: danilo_gsch <danilo_gsch@hotmail.com>

* MecanumDrive doc

Signed-off-by: danilo_gsch <danilo_gsch@hotmail.com>

* MecanumDrive doc

Signed-off-by: danilo_gsch <danilo_gsch@hotmail.com>

* Update MecanumDriveOdometry.cc

line length corrections

* Update include/ignition/math/MecanumDriveOdometry.hh

* CI workflow: use checkout v3 (#519)

Version v2 of the actions/checkout workflow is
deprecated, so switch to v3.

Part of gazebo-tooling/release-tools#862.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>

* Rename COPYING to LICENSE (#521)

The LICENSE file contained a copy of the stanze
used at the top of source code files, while the
actual license was in the COPYING file. So remove
the stanza and put the actual Apache 2.0 license text
in LICENSE.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>

* Custom PID error rate (#525)

* Custom PID error rate

Signed-off-by: Nate Koenig <natekoenig@gmail.com>

* added test

Signed-off-by: Nate Koenig <natekoenig@gmail.com>

---------

Signed-off-by: Nate Koenig <natekoenig@gmail.com>

* Add option to skip pybind11 and SWIG (#480)

Signed-off-by: Michael Carroll <michael@openrobotics.org>

* Disable pybind11 on windows by default (#529)

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>

* 🎈 6.14.0 (#531)

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>

* Lint

Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>

* Port changes and tests from muttistefano

Co-authored-by: muttistefano <mutti.stefano.jp@gmail.com>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>

* Add accessor and TODO note

Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>

---------

Signed-off-by: danilo_gsch <danilo_gsch@hotmail.com>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Nate Koenig <natekoenig@gmail.com>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Co-authored-by: Steve Peters <scpeters@openrobotics.org>
Co-authored-by: Nate Koenig <natekoenig@gmail.com>
Co-authored-by: Michael Carroll <michael@openrobotics.org>
Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org>
Co-authored-by: Michael Carroll <mjcarroll@intrinsic.ai>
Co-authored-by: muttistefano <mutti.stefano.jp@gmail.com>
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Co-authored-by: Michael Carroll <michael@openrobotics.org>
Co-authored-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Merge ign-math6 ➡️  gz-math7
…metricGrid` (#551)

This is needed to resolve a bug in gazebosim/gz-sim#1842 (review). In particular part of the issue is poor API design. Ideally `CreateSession` would return an `Option<Session>`, however it returns a `Session` even if it is not possible to create the session (for instance if it is too far ahead in time or an empty grid). Hence downstream users need a way to verify session validity.


Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Silvio Traversaro <silvio.traversaro@iit.it>
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Co-authored-by: Michael Carroll <michael@openrobotics.org>
Co-authored-by: Michael Carroll <mjcarroll@intrinsic.ai>
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (ba26674) 96.18% compared to head (7160fac) 95.98%.

❗ Current head 7160fac differs from pull request most recent head 3788df3. Consider uploading reports for the commit 3788df3 to get more accurate results

Files Patch % Lines
src/MecanumDriveOdometry.cc 77.77% 24 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #570      +/-   ##
==========================================
- Coverage   96.18%   95.98%   -0.20%     
==========================================
  Files         142      143       +1     
  Lines        9826     9940     +114     
==========================================
+ Hits         9451     9541      +90     
- Misses        375      399      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mjcarroll mjcarroll merged commit daf11d7 into main Nov 14, 2023
@mjcarroll mjcarroll deleted the scpeters/merge_7_8 branch November 14, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants