-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support polynomial piecewise scalar fields #387
Support polynomial piecewise scalar fields #387
Conversation
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Even though later commits build on top of previous ones, each one of them is fairly self-contained. If the size of the PR is beyond what reviewers feel willing to tackle, I can split this PR into multiple ones. FYI @caguero. |
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Codecov Report
@@ Coverage Diff @@
## main #387 +/- ##
==========================================
- Coverage 99.64% 99.20% -0.44%
==========================================
Files 65 70 +5
Lines 6115 6311 +196
==========================================
+ Hits 6093 6261 +168
- Misses 22 50 +28
Continue to review full report at Codecov.
|
I can't see coverage reports, but a few classes definitely could use more unit tests. |
As per f2f chat, I'll be improving test coverage and splitting each commit in this PR into its own PR. |
🎉 New feature
Summary
Spin-off from gazebosim/gz-sim#1357. This PR introduces a number of classes, namely:
to support polynomial piecewise scalar fields.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.