Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support polynomial piecewise scalar fields #387

Closed

Conversation

hidmic
Copy link
Contributor

@hidmic hidmic commented Mar 15, 2022

🎉 New feature

Summary

Spin-off from gazebosim/gz-sim#1357. This PR introduces a number of classes, namely:

  • an Interval class for scalar intervals
  • a Polynomial3 class for cubic polynomials
  • a Region3 class for regions in R^3
  • a SeparableScalarField3 class for separable scalar fields in R^3
  • a PiecewiseScalarField3 class for piecewise scalar fields in R^3

to support polynomial piecewise scalar fields.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

hidmic added 5 commits March 14, 2022 21:23
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic hidmic requested a review from scpeters as a code owner March 15, 2022 00:34
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Mar 15, 2022
@hidmic
Copy link
Contributor Author

hidmic commented Mar 15, 2022

Even though later commits build on top of previous ones, each one of them is fairly self-contained. If the size of the PR is beyond what reviewers feel willing to tackle, I can split this PR into multiple ones.

FYI @caguero.

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@codecov
Copy link

codecov bot commented Mar 15, 2022

Codecov Report

Merging #387 (43f8801) into main (0d05f47) will decrease coverage by 0.43%.
The diff coverage is 82.72%.

❗ Current head 43f8801 differs from pull request most recent head 4b319c7. Consider uploading reports for the commit 4b319c7 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #387      +/-   ##
==========================================
- Coverage   99.64%   99.20%   -0.44%     
==========================================
  Files          65       70       +5     
  Lines        6115     6311     +196     
==========================================
+ Hits         6093     6261     +168     
- Misses         22       50      +28     
Impacted Files Coverage Δ
include/ignition/math/PiecewiseScalarField3.hh 75.00% <75.00%> (ø)
include/ignition/math/Interval.hh 77.04% <77.04%> (ø)
include/ignition/math/Polynomial3.hh 85.71% <85.71%> (ø)
include/ignition/math/Region3.hh 92.30% <92.30%> (ø)
...e/ignition/math/AdditivelySeparableScalarField3.hh 94.73% <94.73%> (ø)
include/ignition/math/Plane.hh 100.00% <0.00%> (ø)
include/ignition/math/Matrix4.hh 100.00% <0.00%> (ø)
include/ignition/math/Inertial.hh 100.00% <0.00%> (ø)
include/ignition/math/MassMatrix3.hh 99.39% <0.00%> (+<0.01%) ⬆️
include/ignition/math/Quaternion.hh 100.00% <0.00%> (+0.24%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebd1a13...4b319c7. Read the comment docs.

@hidmic
Copy link
Contributor Author

hidmic commented Mar 15, 2022

I can't see coverage reports, but a few classes definitely could use more unit tests.

@hidmic hidmic mentioned this pull request Mar 15, 2022
39 tasks
@chapulina chapulina self-requested a review March 16, 2022 16:11
@chapulina chapulina added the MBARI-LRAUV Sponsored by MBARI-LRAUV project: https://github.com/osrf/lrauv label Mar 16, 2022
@hidmic hidmic mentioned this pull request Mar 16, 2022
8 tasks
@hidmic
Copy link
Contributor Author

hidmic commented Mar 16, 2022

As per f2f chat, I'll be improving test coverage and splitting each commit in this PR into its own PR.

@hidmic
Copy link
Contributor Author

hidmic commented Mar 31, 2022

Superseded by #388, #390, #397, and #398.

@hidmic hidmic closed this Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden MBARI-LRAUV Sponsored by MBARI-LRAUV project: https://github.com/osrf/lrauv
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants