Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matrix 4 multiplication test #191

Merged
merged 1 commit into from
Feb 11, 2021
Merged

Matrix 4 multiplication test #191

merged 1 commit into from
Feb 11, 2021

Conversation

chapulina
Copy link
Contributor

Closes #190

Summary

Added a test explicitly checking the result of Matrix 4 multiplication. I believe this addresses the concerns in #190. I ran the tests with both ign-math4 and ign-math6 and the test passes for both.

Test it

Compile and run ./bin/UNIT_Matrix4_TEST

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example world and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review
    another open pull request
    to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina added the tests Broken or missing tests / testing infra label Feb 11, 2021
@chapulina chapulina requested a review from scpeters as a code owner February 11, 2021 18:25
@codecov
Copy link

codecov bot commented Feb 11, 2021

Codecov Report

Merging #191 (b176445) into ign-math4 (00088ff) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           ign-math4     #191   +/-   ##
==========================================
  Coverage      71.59%   71.59%           
==========================================
  Files             67       67           
  Lines           8805     8805           
==========================================
  Hits            6304     6304           
  Misses          2501     2501           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00088ff...b176445. Read the comment docs.

@chapulina chapulina merged commit 92e972e into ign-math4 Feb 11, 2021
@chapulina chapulina deleted the chapulina/4/mat4 branch February 11, 2021 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Broken or missing tests / testing infra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants