Fix INTEGRATION_camera_tracking test #519
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ian Chen ichen@osrfoundation.org
🦟 Bug fix
Fixes #516
Summary
Fix camera tracking integration test. Test is failing because the camera was not able to reach the target pose in time.
Increasing the time the test waits for the camera to get to the target pos fixes the issue for me locally.
Debugging locally shows that the camera does indeed follow the tracked visual and slowly move towards the expected pos but just takes longer. Possible reasons that the test started to fail only recently could be: Tests are run on less powerful machines or GUI updates are becoming more expensive, i.e. performance regression.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.