Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix INTEGRATION_camera_tracking test #519

Merged
merged 1 commit into from
Feb 14, 2023
Merged

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Feb 13, 2023

Signed-off-by: Ian Chen ichen@osrfoundation.org

🦟 Bug fix

Fixes #516

Summary

Fix camera tracking integration test. Test is failing because the camera was not able to reach the target pose in time.
Increasing the time the test waits for the camera to get to the target pos fixes the issue for me locally.

Debugging locally shows that the camera does indeed follow the tracked visual and slowly move towards the expected pos but just takes longer. Possible reasons that the test started to fail only recently could be: Tests are run on less powerful machines or GUI updates are becoming more expensive, i.e. performance regression.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@iche033 iche033 requested a review from jennuine as a code owner February 13, 2023 23:17
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Feb 13, 2023
@iche033 iche033 changed the base branch from gz-gui7 to ign-gui6 February 13, 2023 23:17
@iche033 iche033 added 🏯 fortress Ignition Fortress and removed 🌱 garden Ignition Garden labels Feb 13, 2023
@iche033 iche033 merged commit eef51bf into ign-gui6 Feb 14, 2023
@iche033 iche033 deleted the fix_camera_tracking_test branch February 14, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

🧑‍🌾 MinimalSceneTest.Config failing in gui6 focal CI
3 participants