-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grid config: set values from startup and improve layout #324
Conversation
Signed-off-by: Louise Poubel <louise@openrobotics.org>
examples/config/grid_config.config
Outdated
<cell_count>3</cell_count> | ||
<vertical_cell_count>2</vertical_cell_count> | ||
<cell_length>2</cell_length> | ||
<pose>1 2 3 0 0 0</pose> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<pose>1 2 3 0 0 0</pose> | |
<pose>1 2 3 0 0 0</pose> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been trying to get in the habit of separating position and rotation with an extra space as suggested on Specifying pose: Proposal for a better pose:
libsdformat and SDFormat tutorials should encourage additional whitespace, e.g. to separate translation and rotation, use 3 spaces (instead of 1) as a delimiter between values if they fit on one line, or use a newline (possibly with hanging indents) if they do not fit on one line.
Signed-off-by: Louise Poubel <louise@openrobotics.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I left a minor comment & suggestion but nonblocking
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
…botics/ign-gui into chapulina/6/grid_config Signed-off-by: Louise Poubel <louise@openrobotics.org>
I updated this PR to incorporate
I also deleted the original @jennuine , I made quite a lot of changes from the original PR, mind taking another look? Thanks! |
While looking at the So I'll just note here that the functionality that I migrated to |
Codecov Report
@@ Coverage Diff @@
## ign-gui6 #324 +/- ##
============================================
- Coverage 65.97% 64.48% -1.50%
============================================
Files 34 36 +2
Lines 4782 4953 +171
============================================
+ Hits 3155 3194 +39
- Misses 1627 1759 +132
Continue to review full report at Codecov.
|
Signed-off-by: Louise Poubel <louise@openrobotics.org>
* Added log storing for ign-gui (#272) Signed-off-by: Nikhil Nair <nikhilnicky972@gmail.com> Signed-off-by: Louise Poubel <louise@openrobotics.org> Co-authored-by: Louise Poubel <louise@openrobotics.org> * Don't crash if a plugin has invalid QML (#315) Signed-off-by: Louise Poubel <louise@openrobotics.org> * Set marker point size from message (#317) Signed-off-by: Louise Poubel <louise@openrobotics.org> * Don't set visual scale for point markers (#321) Signed-off-by: Louise Poubel <louise@openrobotics.org> * Fix TopicEcho plugin message display (#322) - Change binding of width property in delegate (see: https://stackoverflow.com/questions/63767669/parent-is-null-in-listview-delegate-after-upgrade-to-qt-5-15) - Use scoped reference to model.display (see: https://forum.qt.io/topic/92085/using-qstringlistmodel-as-model-in-listview) Signed-off-by: Rhys Mainwaring <rhys.mainwaring@me.com> * Use qmldir to define QML module with IgnSpinBox (#319) Signed-off-by: William Wedler <william.wedler@resquared.com> Co-authored-by: Louise Poubel <louise@openrobotics.org> * Add PreRender event to MinimalScene (#325) Signed-off-by: Louise Poubel <louise@openrobotics.org> * Offer a way to disable warnings on marker manager (#326) Signed-off-by: Louise Poubel <louise@openrobotics.org> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Fix codecheck (#329) Signed-off-by: Louise Poubel <louise@openrobotics.org> * Fix codecheck (#332) Signed-off-by: Louise Poubel <louise@openrobotics.org> * Grid config: set values from startup and improve layout (#324) Signed-off-by: Louise Poubel <louise@openrobotics.org> Co-authored-by: Nikhil Nair <43491351+NickNair@users.noreply.github.com> Co-authored-by: Rhys Mainwaring <rhys.mainwaring@me.com> Co-authored-by: Will <1305536+zflat@users.noreply.github.com> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Co-authored-by: Jenn Nguyen <jenn@openrobotics.org>
🎉 New feature
Summary
sceneFromFirstRenderEngine
to reduce duplicationNote to self: backport to
ign-gazebo3
Test it
ign gui -v 4 -c ign-gui/examples/config/grid_config.config
Checklist
Updated migration guide (as needed)codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge
🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸