Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3 ➡️ 4 #196

Merged
merged 2 commits into from
Mar 18, 2021
Merged

3 ➡️ 4 #196

merged 2 commits into from
Mar 18, 2021

Conversation

chapulina
Copy link
Contributor

Forward-port

Port ign-gui3 to ign-gui4.

Branch comparison: ign-gui4...ign-gui3

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@github-actions github-actions bot added the 🔮 dome Ignition Dome label Mar 18, 2021
@codecov
Copy link

codecov bot commented Mar 18, 2021

Codecov Report

Merging #196 (979999a) into ign-gui4 (ec49c33) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           ign-gui4     #196   +/-   ##
=========================================
  Coverage     58.16%   58.16%           
=========================================
  Files            24       24           
  Lines          3069     3069           
=========================================
  Hits           1785     1785           
  Misses         1284     1284           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec49c33...979999a. Read the comment docs.

Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tests on Focal are failing:

  [GUI] [Wrn] [Application.cc:649] [QT] could not connect to display :1.0
  [GUI] [Err] [Application.cc:653] [QT] This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.
  
  Available platform plugins are: eglfs, linuxfb, minimal, minimalegl, offscreen, vnc, xcb.

@chapulina
Copy link
Contributor Author

Some tests on Focal are failing:

All the failures to connect to display are known flakes: #58

@chapulina chapulina merged commit 056240e into ign-gui4 Mar 18, 2021
@chapulina chapulina deleted the chapulina/3_to_4 branch March 18, 2021 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants