Fix world tests #76
Fix world tests #76
Conversation
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## ign-fuel-tools3 #76 +/- ##
===================================================
+ Coverage 85.22% 85.27% +0.04%
===================================================
Files 16 16
Lines 2017 2017
===================================================
+ Hits 1719 1720 +1
+ Misses 298 297 -1
Continue to review full report at Codecov.
|
|
Rather than relying on staging or production endpoints, is the fuel API mock-able with static fixtures and a local http server like python3's http.server? |
|
|
||
| EXPECT_NE(stdOutBuffer.str().find( | ||
| "https://staging-fuel.ignitionrobotics.org"), std::string::npos) | ||
| << stdOutBuffer.str(); | ||
| EXPECT_NE(stdOutBuffer.str().find("1 owners"), std::string::npos) | ||
| << stdOutBuffer.str(); |
There was a problem hiding this comment.
This expectation doesn't appear to be replaced with another one. Was it spurious?
There was a problem hiding this comment.
I removed that on purpose, because it's hard to assume an exact number of users for a given server. Right now for example there are none.
That should be possible. I don't think issue #17 is suggesting exactly that but it's related. |
I think some worlds were removed from the server and this caused the tests to fail.
I also reduced a bit the reliance on the staging server.