7 ➡️ 8 #324
Merged
7 ➡️ 8 #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nate Koenig <nate@openrobotics.org> Signed-off-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org> Signed-off-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org> Signed-off-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org>
* Adds a deprecation warning about fuel.ignitionrobotics.org Signed-off-by: Nate Koenig <nate@openrobotics.org> * Added deprecation notice Signed-off-by: Nate Koenig <nate@openrobotics.org> * spelling Signed-off-by: Nate Koenig <nate@openrobotics.org> * Update tutorials to use gazebo Signed-off-by: Nate Koenig <nate@openrobotics.org> * fix version numbers Signed-off-by: Nate Koenig <nate@openrobotics.org> * Fix some tests Signed-off-by: Nate Koenig <nate@openrobotics.org> * fix codecheck Signed-off-by: Nate Koenig <nate@openrobotics.org> * Retargeting to main Signed-off-by: Nate Koenig <nate@openrobotics.org> * spaces Signed-off-by: Nate Koenig <nate@openrobotics.org> Signed-off-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org>
* Adds a deprecation warning about fuel.ignitionrobotics.org Signed-off-by: Nate Koenig <nate@openrobotics.org> * Added deprecation notice Signed-off-by: Nate Koenig <nate@openrobotics.org> * spelling Signed-off-by: Nate Koenig <nate@openrobotics.org> * Update tutorials to use gazebo Signed-off-by: Nate Koenig <nate@openrobotics.org> * fix version numbers Signed-off-by: Nate Koenig <nate@openrobotics.org> * Change ignitionrobotics.org to gazebosim.org Signed-off-by: Nate Koenig <nate@openrobotics.org> * Fix some tests Signed-off-by: Nate Koenig <nate@openrobotics.org> * fix codecheck Signed-off-by: Nate Koenig <nate@openrobotics.org> * Fixed tests Signed-off-by: Nate Koenig <nate@openrobotics.org> * Update comments with ignitionrobotics Signed-off-by: Nate Koenig <nate@openrobotics.org> * revert change Signed-off-by: Nate Koenig <nate@openrobotics.org> * A few stragglers Signed-off-by: Nate Koenig <nate@openrobotics.org> Signed-off-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org> Signed-off-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
The FuelClient library was only looking for models in ~/.ignition/fuel/fuel.gazebosim.org regardless of which server models were downloaded from when checking if a model is cached. This caused models that used the deprecated ignitionrobotics.org URI to be redownloaded every time. This PR fixes it by adding ignitionrobotics.org as an additional server to check. Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## gz-fuel-tools8 #324 +/- ##
==================================================
+ Coverage 75.10% 75.22% +0.12%
==================================================
Files 20 20
Lines 2864 2882 +18
==================================================
+ Hits 2151 2168 +17
- Misses 713 714 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ahcorde
requested changes
Feb 6, 2023
| @@ -144,5 +142,5 @@ gz fuel edit -p -u https://fuel.gazebosim.org/1.0/OpenRobotics/worlds/Fortress%2 | |||
| Use the `-b` option to make a resource public. For example: | |||
|
|
|||
| ``` | |||
| gz fuel edit -b -u https://fuel.gazebosim.org/1.0/OpenRobotics/worlds/%20Demo --header 'Private-token: YOUR_TOKEN' | |||
| gz fuel edit -b -u https://fuel.gazebosim.org/1.0/OpenRobotics/worlds/Fortress%20Demo --header 'Private-token: YOUR_TOKEN' | |||
There was a problem hiding this comment.
Suggested change
| gz fuel edit -b -u https://fuel.gazebosim.org/1.0/OpenRobotics/worlds/Fortress%20Demo --header 'Private-token: YOUR_TOKEN' | |
| gz fuel edit -b -u https://fuel.gazebosim.org/1.0/OpenRobotics/worlds/Garden%20Demo --header 'Private-token: YOUR_TOKEN' |
There was a problem hiding this comment.
All the examples in this document use Fortress Demo. Any reason to change it to Garden since it's just showing how the gz fuel command works?
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
nkoenig
approved these changes
Feb 8, 2023
iche033
approved these changes
Feb 13, 2023
ahcorde
approved these changes
Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
➡️ Forward port
Port ign-fuel-tools7 to gz-fuel-tools8
Branch comparison: gz-fuel-tools8...ign-fuel-tools7
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)