Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessarily added testing dep #270

Merged
merged 1 commit into from
Jun 29, 2022
Merged

Conversation

mjcarroll
Copy link
Contributor

Signed-off-by: Michael Carroll michael@openrobotics.org

🦟 Bug fix

Summary

@Blast545 noted that this additional dependency snuck in on #269. It is related to some future work I have with using the testing module and not needed at this time. This should resolve broken deb\builder jobs: https://build.osrfoundation.org/job/ign-fuel-tools8-debbuilder/420/

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll mjcarroll requested a review from Blast545 June 29, 2022 15:22
@mjcarroll mjcarroll self-assigned this Jun 29, 2022
@mjcarroll mjcarroll requested a review from nkoenig as a code owner June 29, 2022 15:22
Copy link
Contributor

@Blast545 Blast545 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@codecov
Copy link

codecov bot commented Jun 29, 2022

Codecov Report

Merging #270 (42073a6) into main (6231f53) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #270   +/-   ##
=======================================
  Coverage   73.69%   73.69%           
=======================================
  Files          20       20           
  Lines        2863     2863           
=======================================
  Hits         2110     2110           
  Misses        753      753           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6231f53...42073a6. Read the comment docs.

@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jun 29, 2022
@chapulina chapulina merged commit 9f719f7 into main Jun 29, 2022
@chapulina chapulina deleted the remove_testing_dep branch June 29, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants